Remove the old floating live-caption overlay - #7142
Merged
ComputelessComputer merged 3 commits intoAug 28, 2026
Merged
Conversation
The floating bar already shows the live transcript with a stop button. #6984 re-enabled the retired caption window when adding Win/Linux overlays, so expanding the bar showed both. Keep the old overlay hidden. Co-authored-by: John Jeong <ComputelessComputer@users.noreply.github.com>
✅ Deploy Preview for anarlog canceled.
|
|
|
Expanding live transcript stays in the floating bar with a stop button. The old separate caption overlay stays hidden on every desktop platform. Co-authored-by: John Jeong <ComputelessComputer@users.noreply.github.com>
ComputelessComputer
marked this pull request as ready for review
August 28, 2026 13:32
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5f9216c. Configure here.
The retired caption overlay used to dismiss its settings popover. Hide is now a no-op, and collapsing the in-bar transcript no longer calls it. Co-authored-by: John Jeong <ComputelessComputer@users.noreply.github.com>
ComputelessComputer
deleted the
cursor/remove-old-live-caption-overlay-ba52
branch
August 28, 2026 15:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem: Expanding the recording floating bar also brought back the old rolling live-caption window (opacity slider + Hide). That overlay was retired when the floating bar’s stop/expand transcript panel replaced it, then #6984 rewired it so both surfaces showed at once.
Fix: Windows and Linux keep the same recording UI as macOS: the floating bar with a stop button, and live transcript inside that bar when expanded. The old separate caption overlay is hidden on every desktop platform. Overlay-only settings (caption opacity/position) are removed from the floating-bar settings popover. Live-caption hide is a no-op, so collapsing the in-bar transcript or mounting the host no longer closes the floating-bar settings popover.
Verification
pnpm exec dprint fmt/dprint checkon changed non-Swift filespnpm exec oxlint --quiet --format=github apps/desktop/src/pnpm -F desktop typecheckpnpm -F desktop test(3500 passed)pnpm -F desktop exec vitest run src/meeting-float/host.component.test.tsxafter the Windows/Linux parity testcargo test -p tauri-plugin-windowscould not run here: GTK 3gdk-3.0.pcis not installed in this environment